Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new configuration strategy for httpboot plugin #243

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Conversation

KapilYadava
Copy link
Contributor

@KapilYadava KapilYadava commented Jan 3, 2025

Fixes #206 for httpboot plugin

@KapilYadava KapilYadava added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 3, 2025
@KapilYadava KapilYadava self-assigned this Jan 3, 2025
@KapilYadava KapilYadava requested a review from damyan January 3, 2025 10:41
@KapilYadava KapilYadava marked this pull request as ready for review January 3, 2025 10:41
@damyan
Copy link
Member

damyan commented Jan 8, 2025

Force pushed after rebasing and resolving conflicts, no change

@damyan damyan changed the title Implement new configuration strategy for HTTPBOOT plugin Implement new configuration strategy for httpboot plugin Jan 8, 2025
Copy link
Member

@damyan damyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in the meeting, two small changes are needed:

  • generate test data dynamically (and delete the test configuration file)
  • introduce a new boolean parameter in the config file, e.g. clientSpecific, and use it to determine if a default UKI should be served or a boot service serving client-specific UKIs (as the BootOperator) should be targeted

@KapilYadava
Copy link
Contributor Author

@damyan please review

@damyan damyan added the breaking label Jan 9, 2025
Copy link
Member

@damyan damyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I did some small changes before the merging:

  • fixed some wording
  • reshuffeled some functions around, so the plugin looks similar to others
  • fixed the TestWrongArgs test, which was broken
  • refactored the client-specific tests, deduplicated some code

@damyan damyan merged commit c2b755a into main Jan 16, 2025
8 checks passed
@damyan damyan deleted the enh/httpboot branch January 16, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking documentation Improvements or additions to documentation enhancement New feature or request size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor plugins configuration
2 participants