-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new configuration strategy for httpboot
plugin
#243
Conversation
Force pushed after rebasing and resolving conflicts, no change |
httpboot
plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the meeting, two small changes are needed:
- generate test data dynamically (and delete the test configuration file)
- introduce a new boolean parameter in the config file, e.g.
clientSpecific
, and use it to determine if a default UKI should be served or a boot service serving client-specific UKIs (as theBootOperator
) should be targeted
069f2db
to
da3ca14
Compare
@damyan please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I did some small changes before the merging:
- fixed some wording
- reshuffeled some functions around, so the plugin looks similar to others
- fixed the
TestWrongArgs
test, which was broken - refactored the client-specific tests, deduplicated some code
Fixes #206 for
httpboot
plugin